[Pgpool-hackers] patch "Caching query results in pgpool-II"

[Masanori Yamazaki]

Mentor (Tatsuo Ishii)

I am sending patch file. My progress status are the following.
This pache is not completed, so test is insufficient(especially extended
protocol and function which write tableoid in file).
In addition, Memcached connection is executed every time because keeping
connection doesn't working now.
The number of comments or pool_debug has been increased more than last time.

1) Shared memory cache
  None
2) Cache data when extended protocol is used
  Working(memcached), None(shmem)
3) Cache invalidation when receives DDL/DML related to query cache
  Working
4) Cache should not be registered if transaction aborts
  None
5) Cache should not be registered if the table is temporary table
  None
6) configure does not recognize "--with-memcached" option.
  Done
7) All memory cache codes using memcached should be surrounded by
  #ifdef USE_MEMCACHED ... #endif
  Done
8) directive "memqcache_dir" is missing
  Done
9) Documentation patches are not included
  Done
10) Patches for pgpool.conf.sample-master-
slave
   pgpool.conf.sample-stream pgpool.conf.sample-replication are not
   included
       None


-- 
best regards
Masanori YAMAZAKI
email: m.yamazaki23 at gmail.com


2011/6/30 Tatsuo Ishii <ishii at sraoss.co.jp>

> >>> 3) What is this code doing? "con" is never
> >>>   used. memqcache_total_size's 3rd arg is "oid", while you are
> >>>   passing a file descriptor.
> >>>        /* save the received result to buf for each kind */
> >>>        if (pool_config->memory_cache_
> > enabled)
> >>>        {
> >>>                char* con;
> >>>                memqcache_register(kind, frontend, frontend->fd, p1,
> > len1);
> >>>        }
> > I corrected it. I think that "backend->info->key" is table oid.
> > Is it wrong?
>
> Wrong. See ConnectionInfo.
>
>        int                     key;    /* cancel key */
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese: http://www.sraoss.co.jp
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://pgfoundry.org/pipermail/pgpool-hackers/attachments/20110711/da91f5c8/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.tar.gz
Type: application/x-gzip
Size: 15547 bytes
Desc: not available
URL: <http://pgfoundry.org/pipermail/pgpool-hackers/attachments/20110711/da91f5c8/attachment.bin>