[Pgpool-hackers] health_check_password configuration option

[Tatsuo Ishii]

Committed. Thanks!
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp

> Hello,
> 
> On 06/07/2011 14:48, Tatsuo Ishii wrote:
>> Hi Nicolas,
>> 
>>> We are currently not able to specify the password of the health check
>>> user, which is needed at least for streaming replication lag.  So I
>>> added the possibility to specify it in the configuration file, in the
>>> attached patch.
>> 
>> Great idea. I will commit as soon as possible.
> 
> Sorry, I forgot to include the update of the English documentation in
> the patch.
> 
>>> Also, I find the error message in check_replication_time_lag()
>>> (pool_worker_child.c) not friendly :
>>>
>>> pool_error("check_replication_time_lag: DB node is valid but no
>>> persistent connection");
>>>
>>> What about sending this error message to the debug level and adding a
>>> second message on the error level?  Fro example:
>>>
>>> pool_error("check_replication_time_lag: could not connect to DB node %d,
>>> check health check configuration", i);
>> 
>> Agreed.
> 
> Done inside the new version of the patch, attached.
> 
>> --
>> Tatsuo Ishii
>> SRA OSS, Inc. Japan
>> English: http://www.sraoss.co.jp/index_en.php
>> Japanese: http://www.sraoss.co.jp
> 
> -- 
> Nicolas Thauvin
> DBA
> http://www.dalibo.com