[pgpool-hackers: 4399] Re: NAMEDATALEN 128

[Igor Yurchenko]

Hi...

Wow, great! Is it effective for pgpool4.2?

BTW, another question. I didn't check a code and would like to clarify,
pgpoolAdmin also should be recompiled for NAMEDATALEN 128?

On Wed, 20 Sept 2023, 9:22 Tatsuo Ishii, <ishii at sraoss.co.jp> wrote:

> Sorry for late.  I have pushed a commit to eliminate duplicating
> defines for NAMEDATALEN to master branch. Now it is defined in
> pg_config_manual.h only.
>
>
> https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=3bd6941f193073ae9b9a646db096e78a2b6dd4ce
>
> I had to give up the idea below: stop copying pg_config_manual.h from
> PostgreSQL.  Our pg_config_manual.h has modified original one and this
> makes removing the file a little bit harder.
>
> >  Ah, yeah, really... It sounds much better.
> > BR
> > Igor Yurchenko
> >
> >
> > On Mon, 14 Aug 2023 at 13:37, Tatsuo Ishii <ishii at sraoss.co.jp> wrote:
> >
> >> > Hi
> >> > Great! Thanks!
> >> > It may be a point in addition to pull the parameter up to the options
> of
> >> > ./configure with a default value 64.
> >>
> >> I am not sure it's a good idea. If pgpool does that and PostgreSQL's
> >> NAMEDATALEN remains the default, the result will be a disaster.  While
> >> building pgpool, I think pgpool should look into PostgreSQL's
> >> pg_config_manual.h where NAMEDATALEN resides, rathter copying the
> >> file. This way, pgpool could sync with PostgreSQL's NAMEDATALEN.
> >>
> >> Best reagards,
> >> --
> >> Tatsuo Ishii
> >> SRA OSS LLC
> >> English: http://www.sraoss.co.jp/index_en/
> >> Japanese:http://www.sraoss.co.jp
> >>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.pgpool.net/pipermail/pgpool-hackers/attachments/20230920/f46d2b31/attachment.htm>