[pgpool-hackers: 4171] Re: Allow pgpool_setup to test sample scripts and config files included in RPMs

Bo Peng pengbo at sraoss.co.jp
Fri Jun 10 15:17:33 JST 2022


Thank you Ishii-san for your comments.

I have added the usage messages and updated the pgpool_setup docs.
Patch is attached.

Best regards,

On Wed, 08 Jun 2022 22:02:20 +0900 (JST)
Tatsuo Ishii <ishii at sraoss.co.jp> wrote:

> Hi Peng,
> 
> > Thank you for testing my patch.
> > I have fixed this timeout error. Patch is attached.
> > 
> > Because I have changed the backend_hostname to "lcoalhost",
> > I need to change $PGSOCKET_DIR to "localhost" in test 055.
> > 
> >   grep "Failover done. shutdown host $PGSOCKET_DIR(11003)" log/pgpool.log > /dev/null 2>&1
> 
> After applying the new patch all the regression tests passed. Great!
> 
> I would suggest to update the usage message of pgpool_setup so that
> the new "-c" option is shown. Also it would be nice if you update the
> pgpool_setup manual to reflect your changes.
> 
> Best reagards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp


-- 
Bo Peng <pengbo at sraoss.co.jp>
SRA OSS, Inc. Japan
https://www.sraoss.co.jp/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_rpms_v3.patch
Type: application/octet-stream
Size: 26179 bytes
Desc: not available
URL: <http://www.pgpool.net/pipermail/pgpool-hackers/attachments/20220610/e6a4b6fd/attachment-0001.obj>


More information about the pgpool-hackers mailing list