[pgpool-hackers: 4063] Re: pg_terminate_backend

[Tatsuo Ishii]

> On Mon, Nov 15, 2021 at 11:24 AM Tatsuo Ishii <ishii at sraoss.co.jp> wrote:
> 
>> Hi Usama,
>>
>> Now that the number of argument in pg_terminate_backend of PostgreSQL
>> 14 is 2, rather than 1, I think we need to update pool_select_walker.c:
>>
>>                         if (ctx->pg_terminate_backend_pid == 0 &&
>> strcmp("pg_terminate_backend", strVal(llast(fcall->funcname))) == 0)
>>                         {
>>                                 if (list_length(fcall->args) == 1)
>>                                 {
>>
>> What do you think?
>>
> 
> Yes that is correct, and since the timeout argument is optional so the
> pool_select_walker need to
> look for both single and two argument versions of the function.

Thanks. I have pushed the fix.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp