[pgpool-hackers: 3698] 答复: [patch] enable specific argument name for function in pgpool_adm

Hou, Zhijie houzj.fnst at cn.fujitsu.com
Mon Jul 6 14:58:16 JST 2020


Hi Ishii san,

> One thing I noticed is you use following syntax in the manual patch:

> +    test=# SELECT * FROM pcp_node_info(node_id := 1, host := '', port := 11001, username := 't-ishii', password := 't-ishii');

> ":=" is an old syntax and I think it'd be better to use "=>" instead:

> https://www.postgresql.org/docs/12/sql-syntax-calling-funcs.html

Thanks for your review.
you are right, It's better to use "=>", and I made a new patch.

Thanks
Best regards,
houzj




-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Update-pgpool_adm-1.2-1.3.sql.patch
Type: application/octet-stream
Size: 2211 bytes
Desc: 0001-Update-pgpool_adm-1.2-1.3.sql.patch
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20200706/d804927c/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Update-pgpool_adm-1.3.sql.patch
Type: application/octet-stream
Size: 6855 bytes
Desc: 0001-Update-pgpool_adm-1.3.sql.patch
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20200706/d804927c/attachment-0003.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_for_en_doc.tar
Type: application/x-tar
Size: 11776 bytes
Desc: patch_for_en_doc.tar
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20200706/d804927c/attachment-0002.tar>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_for_jp_doc.tar
Type: application/x-tar
Size: 11776 bytes
Desc: patch_for_jp_doc.tar
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20200706/d804927c/attachment-0003.tar>


More information about the pgpool-hackers mailing list