[pgpool-hackers: 3356] Re: Import PostgreSQL12 Parser

Tatsuo Ishii ishii at sraoss.co.jp
Fri Jul 19 11:00:24 JST 2019


Thanks. The patch looks good for me.

> Ishii-san,
> 
> Thank you for testing my patch.
> 
> I have to do "git diff HEAD" to create the patch.
> I made the patch again and fixed some whitespace.
> 
> Please see the attachment.
> 
> On Thu, 18 Jul 2019 15:51:44 +0900 (JST)
> Tatsuo Ishii <ishii at sraoss.co.jp> wrote:
> 
>> Oops. I should have written in English.
>> 
>> The patch does not apply cleanly.
>> Have you done git add -N before doing git diff?
>> 
>> > 石井です。
>> > 
>> > とりあえず、パッチはうまく当たりませんでした。
>> > 
>> > もしかして、src/include/parser/kwlist_d.hなどをgit add -Nする前にgit diff
>> > しましたか?
>> > 
>> > $ >
>> > /home/t-ishii/import_pg12_parser_v1.patch:4571: trailing whitespace.
>> > const uint8 ScanKeywordCategories[SCANKEYWORDS_NUM_KEYWORDS] = { 
>> > /home/t-ishii/import_pg12_parser_v1.patch:7031: space before tab in indent.
>> >     	CopyStmt *c_stmt = (CopyStmt *) stmt;
>> > error: src/include/parser/kwlist_d.h: そのようなファイルやディレクトリはありません
>> > error: src/include/parser/kwlookup.h: そのようなファイルやディレクトリはありません
>> > error: src/parser/kwlookup.c: そのようなファイルやディレクトリはありません
>> > 
>> >> Hi all,
>> >> 
>> >> The attached patch imports PostgreSQL12 beta2 parser to Pgpool-II 4.1.
>> >> 
>> >> Major chanegs of PostgreSQL11 parser include:
>> >> 
>> >> - Add new VACUUM options:
>> >>   -- SKIP_LOCKED
>> >>   -- INDEX_CLEANUP
>> >>   -- TRUNCATE
>> >> 
>> >> - Add COMMIT AND CHAIN and ROLLBACK AND CHAIN commands
>> >> 
>> >> - Add a WHERE clause to COPY FROM
>> >> 
>> >> - Allow to use CREATE OR REPLACE AGGREGATE command
>> >> 
>> >> - Allow to use mcv (most-common-value) in CREATE STATISTICS
>> >> 
>> >> - ADD REINDEX option CONCURRENTLY 
>> >> 
>> >> - Add EXPLAIN option SETTINGS
>> >> 
>> >> - etc.
>> >> 
>> >> -- 
>> >> Bo Peng <pengbo at sraoss.co.jp>
>> >> SRA OSS, Inc. Japan
>> > 
>> 
> 
> 
> -- 
> Bo Peng <pengbo at sraoss.co.jp>
> SRA OSS, Inc. Japan


More information about the pgpool-hackers mailing list