[pgpool-hackers: 3219] Re: watchdog lifecheck method with query mode does not work in 4.0.
ishii at sraoss.co.jp
Fri Jan 11 09:30:29 JST 2019
> Hi Ishii-San
> On Thu, Jan 10, 2019 at 11:52 AM Tatsuo Ishii <ishii at sraoss.co.jp> wrote:
>> It is pointed out that watchdog lifecheck method with query mode does
>> not work since 4.0.
>> The cause of this is using thread unsafe function
>> get_pgpool_config_user_password(). Making it thread safe requires none
>> trivial work. So I tend to agree that we disable using AES encrypted
>> password for lifecheck method = "query".
> Yes that's true, making get_pgpool_config_user_password thread safe would
> be lot of work.
> I am thinking what if change the code and call
> get_pgpool_config_user_password() from outside the thread function before
> the threads and pass in the password as the argument to the thread
> function. This way we can keep supporting the AES encrypted
> password for lifecheck method = "query"
Sounds a nice idea. Can you please come up with a propose patch?
SRA OSS, Inc. Japan
More information about the pgpool-hackers