[pgpool-general: 7773] Re: problem connecting to backend

[Tatsuo Ishii]

> quick question
> 
> for this part of your patch
> 
> @@ -189,7 +196,10 @@ pvsnprintf(char *buf, size_t len, const char *fmt,
> va_list args)
>   }
> 
>   if (len >= MaxAllocSize / 2)
> + {
> + errno = save_errno;
>   return MaxAllocSize;
> + }
> 
>   return len * 2;
>  }
> 
> wouldnt it be better to do it like this?

Yes, you are right.

> @@ -189,7 +196,10 @@ pvsnprintf(char *buf, size_t len, const char *fmt,
> va_list args)
>   }
> 
> + errno = save_errno;
>   if (len >= MaxAllocSize / 2)
>      return MaxAllocSize;
> 
>   return len * 2;
>  }
> 
> in order to cover both returns ?

Ditto.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp