[pgpool-committers: 3768] pgpool: Remove pool_log/pool_error calls from signal handlers.

Tatsuo Ishii ishii at postgresql.org
Wed Jan 11 09:43:03 JST 2017

Remove pool_log/pool_error calls from signal handlers.

pool_log/pool_error calls malloc(), which is not safe to be called
inside signal handlers, per discussion in [pgpool-hackers: 1950].  I
ifdef out them, rather than simply remove them in a hope we someday
find a better solution which make calling the functions inside signal

Not that I did not touch exit_handler() of pgpool_main.c because
removing pool_log/pool_debug from them loses informative message like
"received smart shutdown request". Pgpool-II main process do not
heavily use malloc(), so the risk is minimum, I guess.



Modified Files
child.c | 12 +++++++++++-
main.c  |  2 +-
2 files changed, 12 insertions(+), 2 deletions(-)

More information about the pgpool-committers mailing list