[Pgpool-hackers] Reverting pgpool.conf reorganization patch

[Guillaume Lelarge]

On Thu, 2011-08-25 at 15:31 +0900, Tatsuo Ishii wrote:
> > On Thu, 2011-08-25 at 12:57 +0900, Tatsuo Ishii wrote:
> >> Hi,
> >> 
> >> I'm thinking about reverting patches below or at least remove "in the
> >> middle of line comment" like this:
> >> 
> >> listen_addresses = 'localhost'     # Host name or IP address to listen on:
> >> 
> >> The reason why I propose is, this format change breaks pgpoolAdmin. I
> >> know current pgpoolAdmin does not catch up pgpool-II 3.1's new
> >> configurations but beside this pgpoolAdmin has been able to be used
> >> with newer version of pgpool-II. Unfortunately the patch completely
> >> breaks it. Unless some one comes up with fixing pgpoolAdmin for the
> >> problem, I think we should revert or remove the new style commnents
> >> from pgpool-II 3.1 pgpool.conf.*. 
> >> 
> >> (SRA OSS could contribute this but will not happen immediately, or at
> >> least by the end of August, which is supposed to be release date of
> >> pgpool-II 3.1.)
> >> 
> >> Comments?
> >> 
> > 
> > If the only issue is with comments which don't start at the beginning of
> > a line, I think it's better to fix the comments rather than reverting
> > the fix. I can do it.
> 
> Could you please do it?
> 

It's done.


-- 
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com