[Pgpool-hackers] Reverting pgpool.conf reorganization patch

[Tatsuo Ishii]

> On Thu, 2011-08-25 at 12:57 +0900, Tatsuo Ishii wrote:
>> Hi,
>> 
>> I'm thinking about reverting patches below or at least remove "in the
>> middle of line comment" like this:
>> 
>> listen_addresses = 'localhost'     # Host name or IP address to listen on:
>> 
>> The reason why I propose is, this format change breaks pgpoolAdmin. I
>> know current pgpoolAdmin does not catch up pgpool-II 3.1's new
>> configurations but beside this pgpoolAdmin has been able to be used
>> with newer version of pgpool-II. Unfortunately the patch completely
>> breaks it. Unless some one comes up with fixing pgpoolAdmin for the
>> problem, I think we should revert or remove the new style commnents
>> from pgpool-II 3.1 pgpool.conf.*. 
>> 
>> (SRA OSS could contribute this but will not happen immediately, or at
>> least by the end of August, which is supposed to be release date of
>> pgpool-II 3.1.)
>> 
>> Comments?
>> 
> 
> If the only issue is with comments which don't start at the beginning of
> a line, I think it's better to fix the comments rather than reverting
> the fix. I can do it.

Could you please do it?

> I, obviously, don't agree to revert it (because I think it is much
> easier to configure pgpool with the new file), so let you do it if you
> want to revert it.

I don't think we need to revert whole patch if you can fix comments
not starting at beginning of a line.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp

>> Subject: [Pgpool-committers] pgpool - pgpool-II: Reorganize pgpool.conf sample files so that they are
>> From: gleu at pgfoundry.org (User Gleu)
>> To: pgpool-committers at pgfoundry.org
>> Date: Sun, 30 Jan 2011 16:16:33 +0000 (UTC)
>> Sender: pgpool-committers-bounces at pgfoundry.org
>> X-Mailer: activitymail 1.26, http://search.cpan.org/dist/activitymail/
>> X-Mew: tab/spc characters on Subject: are simplified.
>> 
>> Log Message:
>> -----------
>> Reorganize pgpool.conf sample files so that they are easier to read.
> 
> 
> -- 
> Guillaume
>   http://blog.guillaume.lelarge.info
>   http://www.dalibo.com
>