[Pgpool-hackers] hardcoded values in configure script

[Yoshiyuki Asaba]

Hi,

From: Devrim GUNDUZ <devrim at commandprompt.com>
Subject: [Pgpool-hackers] hardcoded values in configure script
Date: Mon, 02 Oct 2006 17:03:58 +0300

> Today I had some time to eliminate RPM errors of pgpool-II. I found
> something that rpmlint complains. Here are two lines in configure:
> 
> PGSQL_INCLUDE_DIR=/usr/local/pgsql/include
> PGSQL_LIB_DIR=/usr/local/pgsql/lib

These are default values. So you need to give options which are
"--with-pgsql-include" and "--with-pgsql-lib". Could you try the
attached patch?

--
Yoshiyuki Asaba
y-asaba at sraoss.co.jp

> 
> I checked Slony-I code and saw that they got these values by running
> pg_config --includedir and --libdir. Should we use the same style
> instead of hardcoding these values? This requires some configure script
> hacking that I'm not too much familiar with. For now, I added a patch to
> RPM builds which changes these values (RPM needs /usr/include/pgsql
> and /usr/lib/pgsql for these two options, respectively); but this is a
> dirty solution.
> 
> Regards,
> -- 
> The PostgreSQL Company - Command Prompt, Inc. 1.503.667.4564
> PostgreSQL Replication, Consulting, Custom Development, 24x7 support
> Managed Services, Shared and Dedicated Hosting
> Co-Authors: plPHP, plPerlNG - http://www.commandprompt.com/
> 
-------------- next part --------------
Index: pgpool.spec
===================================================================
RCS file: /cvsroot/pgpool/pgpool-II/pgpool.spec,v
retrieving revision 1.2
diff -c -r1.2 pgpool.spec
*** pgpool.spec	27 Sep 2006 05:45:04 -0000	1.2
--- pgpool.spec	3 Oct 2006 01:57:17 -0000
***************
*** 21,27 ****
  CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS
  CXXFLAGS="${CXXFLAGS:-%optflags}" ; export CXXFLAGS
  
! %configure --bindir=%{_bindir} --sysconfdir=%{_sysconfdir} --mandir=%{_mandir} --libdir=%{_libdir}
  
  make %{?smp_flags}
  
--- 21,27 ----
  CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS
  CXXFLAGS="${CXXFLAGS:-%optflags}" ; export CXXFLAGS
  
! %configure --bindir=%{_bindir} --sysconfdir=%{_sysconfdir} --mandir=%{_mandir} --libdir=%{_libdir} --with-pgsql-include=/usr/include/pgsql --with-pgsql-lib=/usr/lib/pgsql
  
  make %{?smp_flags}