[pgpool-hackers: 4176] Re: Rename configuration parameter delegate_IP to delegate_ip

Tatsuo Ishii ishii at sraoss.co.jp
Mon Jun 13 17:28:50 JST 2022


> Hi Ishii-san,
> 
>> Hi Peng,
>> 
>> > +static bool
>> > +DelegateIPAssignMessage(ConfigContext scontext, char *newval, int elevel)
>> > +{
>> > +	if (scontext != CFGCXT_BOOT)
>> > +		ereport(WARNING,
>> > +				(errmsg("delegate_IP is changed to delegate_ip"),
>> > +				 errdetail("if fail_over_on_backend_error is specified, the value will be set to failover_on_backend_error")));
>> 
>> The errdetail does not seem to match with the errmsg. 
> 
> Thank you for your review.
> 
> It was a typo.
> The fixed patch is attached.

Looks good to me.

Best reagards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp


More information about the pgpool-hackers mailing list