[pgpool-hackers: 3929] Re: Allow pcp_node_ino to list all backend nodes information

[Bo Peng]

Ishii-san,

Thank you for your review.
I am going to commit this patch.

On Sun, 13 Jun 2021 12:03:07 +0900 (JST)
Tatsuo Ishii <ishii at sraoss.co.jp> wrote:

> > I created a patch to allow pcp_node_info command to 
> > list all backend nodes information.
> > 
> > Currently pcp_node_info command can only display the node information 
> > which is specified using "-n" or "--node-id" option.
> > 
> >   $ pcp_node_info -w -p 11001 -n 0
> >   /tmp 11002 1 0.500000 waiting up primary primary 0 none none 2021-06-12 01:00:21
> > 
> >   $ pcp_node_info -w -p 11001 -n 1
> >   /tmp 11003 1 0.500000 waiting up standby standby 0 streaming async 2021-06-12 01:00:21
> > 
> > 
> > This patch allows pcp_node_info command to list all backend nodes information 
> > using "-a" or "--all" option.
> > 
> >   $ pcp_node_info -w -p 11001 -a 
> >   /tmp 11002 1 0.500000 waiting up primary primary 0 none none 2021-06-12 01:00:21
> >   /tmp 11003 1 0.500000 waiting up standby standby 0 streaming async 2021-06-12 01:00:21
> > 
> >   $ pcp_node_info -w -p 11001 -a -v
> >   Hostname               : /tmp
> >   Port                   : 11002
> >   Status                 : 1
> >   Weight                 : 0.500000
> >   Status Name            : waiting
> >   Backend Status Name    : up
> >   Role                   : primary
> >   Backend Role           : primary
> >   Replication Delay      : 0
> >   Replication State      : none
> >   Replication Sync State : none
> >   Last Status Change     : 2021-06-12 01:00:21
> > 
> >   Hostname               : /tmp
> >   Port                   : 11003
> >   Status                 : 1
> >   Weight                 : 0.500000
> >   Status Name            : waiting
> >   Backend Status Name    : up
> >   Role                   : standby
> >   Backend Role           : standby
> >   Replication Delay      : 0
> >   Replication State      : streaming
> >   Replication Sync State : async
> >   Last Status Change     : 2021-06-12 01:00:21
> 
> The patch applied cleanly, compiled fine, and worked as
> advertised. Also all regression tests passed. Thank you for the great
> work!
> 
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp


-- 
Bo Peng <pengbo at sraoss.co.jp>
SRA OSS, Inc. Japan
http://www.sraoss.co.jp/