[pgpool-hackers: 2969] Re: changing fail-over to failover

[Muhammad Usama]

On Sat, Aug 18, 2018 at 5:07 AM Tatsuo Ishii <ishii at sraoss.co.jp> wrote:

> Hi Usama,
>
> > Hi Ishii-San
> >
> > Please find the attached patch to fix mistakes where "fail_over" and
> > "fail-over" were used instead of the "failover". And that also includes a
> > wrongly spelled configuration parameter "fail_over_on_backend_error",
> > The patch throws the warning message when old config name
> > fail_over_on_backend_error is used instead of failover_on_backend_error
> and
> > suggests to use the correct name, while using the old config variable
> name
> > has no effect.
> >
> > What do you think of the approach to throw a waring message and making
> the
> > old variable name ineffective.
>
> Looks good to me.
>

Thanks for the review, I have pushed it to master branch.

Kind regards
Muhammad Usama


>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-hackers/attachments/20180819/0db72ea7/attachment.html>