[pgpool-hackers: 726] Re: [pgpool-committers: 2350] pgpool: Fix for 0000122: pgpool-II 3.4.0 - if_up_cmd and if_down_cmd $_

[Tatsuo Ishii]

Usama,

Doesn't this need to be back patched to 3.2 as well?

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

From: Muhammad Usama <m.usama at gmail.com>
Subject: [pgpool-committers: 2350] pgpool: Fix for 0000122: pgpool-II 3.4.0 - if_up_cmd and if_down_cmd $_
Date: Fri, 12 Dec 2014 18:33:04 +0000
Message-ID: <E1XzV1U-0005Wp-Ai at gothos.postgresql.org>

> Fix for 0000122: pgpool-II 3.4.0 - if_up_cmd and if_down_cmd $_IP_$ substitution
> is too optimistic.
> 
> exec_ifconfig() function while breaking the command string into tokens was
> assuming that "$_IP_$" keyword will always have a white space at the end and
> when "$_IP_$" has some prefix, it gets broken down into two tokens "$_IP_$"
> instead of one.
> To fix this the command string in exec_ifconfig() is passed to newly added
> string_replace() function to substitute all occurrences of "$_IP_$"
> with delegate_IP before tokenizing.
> 
> Branch
> ------
> master
> 
> Details
> -------
> http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=4e495b960175598805bb370eacaca4e492862b90
> 
> Modified Files
> --------------
> src/watchdog/wd_if.c |   58 ++++++++++++++++++++++++++++++++++++++++----------
> 1 file changed, 47 insertions(+), 11 deletions(-)
> 
> _______________________________________________
> pgpool-committers mailing list
> pgpool-committers at pgpool.net
> http://www.pgpool.net/mailman/listinfo/pgpool-committers