[pgpool-general: 7004] found some unnecessary checks in pool_auth.c

sherlockcpp sherlockcpp at foxmail.com
Wed Apr 22 22:54:33 JST 2020


I found some unnecessary checks in pool_auth.c,
Like the following code,  if first check 'reauth == true' , function has returned,
I think ,may be the second check can be removed , and I make a patch for it

if (reauth)
	return 0;

if (!reauth && kind == AUTH_REQ_OK)

Best regards,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-general/attachments/20200422/1ca5a336/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Fix-Unnecessary-check.patch
Type: application/octet-stream
Size: 710 bytes
Desc: not available
URL: <http://www.sraoss.jp/pipermail/pgpool-general/attachments/20200422/1ca5a336/attachment.obj>

More information about the pgpool-general mailing list