[pgpool-general: 6974] Re: found some messages never output

Muhammad Usama m.usama at gmail.com
Tue Apr 14 21:05:14 JST 2020


On Mon, Apr 13, 2020 at 9:30 AM Tatsuo Ishii <ishii at sraoss.co.jp> wrote:

> Hi Usama,
>
> Do you have an opinion on this?
> I feel like sherlockcpp is correct but I want to confirm it.
>
>
Yes, that is correct. This is an obvious mistake in the code and somehow
overlooked by commit:ef6c0c8fb0899c65d37c2d83150683a952bad756
Thanks sherlockcpp for pointing this out. And this also needs to be fixed
in 4.0 and master branch as well.


Best Regards
Muhammad Usama

Best regards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
>
> From: "sherlockcpp" <sherlockcpp at foxmail.com>
> Subject: [pgpool-general: 6956] found some messages never output
> Date: Tue, 7 Apr 2020 19:08:36 +0800
> Message-ID: <tencent_0DE95D0F6D6F7DB17EEF3FB1 at qq.com>
>
> > Hello,
> >
> >
> > When reading pgpool's code, I found some messages never output
> > in function wd_get_failover_result_from_data().
> >
> >
> > There are two same if condition, so the second condition is always false.
> > For branch4.1 ,the code is as follows.
> > ------------src/watchdog/wd_commands.c:721--------------------------
> > 723     if (result == NULL)
> > 724         return FAILOVER_RES_ERROR;
> > 725
> > 726     if (result == NULL)
> > 727     {
> > 728         ereport(WARNING,
> > 729                 (errmsg("failover command on watchdog failed"),
> > 730                  errdetail("issue command to watchdog returned
> NULL")));
> > 731         return FAILOVER_RES_ERROR;
> > 732     }
> >
> > --------------------------------------
> >
> >
> > I think the warning messages should be output here,
> > And I make a patch for pgpool branch 4.1.
> >
> >
> > Best regards
> > sherlockcpp
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-general/attachments/20200414/75bcecf0/attachment.html>


More information about the pgpool-general mailing list