[pgpool-general: 6956] found some messages never output

[sherlockcpp]

Hello,


When reading pgpool's code, I found some messages never output
in function wd_get_failover_result_from_data().


There are two same if condition, so the second condition is always false.
For branch4.1 ,the code is as follows.
------------src/watchdog/wd_commands.c:721--------------------------
723     if (result == NULL)
724         return FAILOVER_RES_ERROR;
725
726     if (result == NULL)
727     {
728         ereport(WARNING,
729                 (errmsg("failover command on watchdog failed"),
730                  errdetail("issue command to watchdog returned NULL")));
731         return FAILOVER_RES_ERROR;
732     }

--------------------------------------


I think the warning messages should be output here, 
And I make a patch for pgpool branch 4.1.


Best regards
sherlockcpp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-general/attachments/20200407/118c020d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Fix-some-error-messages-never-output.patch
Type: application/octet-stream
Size: 508 bytes
Desc: not available
URL: <http://www.sraoss.jp/pipermail/pgpool-general/attachments/20200407/118c020d/attachment.obj>