[pgpool-general: 6951] Fix-condition-tok-is-always-true

Mon Apr 6 17:29:02 JST 2020

Hello,

In pool_passwd.c:391
I found the condition “if (tok)” is is always true, Because previous condition has already checked that.

the code is as follows (the code following dose not seem to be used now, But for security, we'd better fix it)
---------------------------------
383&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;/* Get backend user */
384&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;t = getNextToken(t, &amp;tok);
385&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;if (tok)
386&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;{
387&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;/* check if we also have the password */
388&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;char&nbsp; &nbsp; &nbsp; &nbsp;*pwd;
389
390&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;t = getNextToken(t, &amp;pwd);
391&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;if (tok)
392&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;{
393&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;pwdMapping-&gt;backendUser.password = pwd;
394&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;pwdMapping-&gt;backendUser.userName = tok;
395&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;pwdMapping-&gt;backendUser.passwordType = get_password_type(pwdMapping-&gt;backendUser.password);
396&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;pwdMapping-&gt;mappedUser = true;
397&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;}
398&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;}
399&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;break;

---------------------------------

I think the condition that really need to be checked here is ”if (pwd)“.

Best regards
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-general/attachments/20200406/968b7127/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Fix-condition-tok-is-always-true.patch
Type: application/octet-stream
Size: 385 bytes
Desc: not available
URL: <http://www.sraoss.jp/pipermail/pgpool-general/attachments/20200406/968b7127/attachment.obj>