[pgpool-general: 1036] Re: Problem with pgpool when using SSL for client/pgpool communication

Tim Spencer tspencer at cloudpassage.com
Sat Sep 22 02:33:35 JST 2012


Hello!

	I am the client mentioned in http://www.sraoss.jp/pipermail/pgpool-general/2012-July/000762.html.  I just wanted to let you all know that I gave ishii at sraoss.co.jp access to our staging envionment, and he was able to figure out the corner case that we were hitting pretty quickly, and gave us a patch.  It's been running well for a day now under load, and so I believe the issue to be fixed.  We now can turn SSL back on for our production machines.  Thanks so much for your help!

	It sounds like he plans on checking it in so nobody else will have this problem going forward either.  I pasted it in at the bottom of this email too.  Yay!

		-tspencer

diff --git a/pool_process_query.c b/pool_process_query.c
index ecaf6e9..a163089 100644
--- a/pool_process_query.c
+++ b/pool_process_query.c
@@ -386,7 +386,8 @@ POOL_STATUS pool_process_query(POOL_CONNECTION *frontend,
		}
		else
		{
-			if (!pool_read_buffer_is_empty(frontend) && !pool_is_query_in_progress())
+			if ((pool_ssl_pending(frontend) || !pool_read_buffer_is_empty(frontend)) &&
+				!pool_is_query_in_progress())
			{
				/* We do not read anything from frontend after receiving X packet.
				 * Just emit log message. This will guard us from buggy frontend.



More information about the pgpool-general mailing list