[pgpool-committers: 3411] Re: pgpool: Fix confusing error messages.

[Muhammad Usama]

Hi Ishii-San

I think there is a little problem with this commit. Since this commit is
throwing ereport( ERROR,..) before "if
 (pool_config->fail_over_on_backend_error)"statementand ereport ERROR will
always jump the code to error handler, and the fail_over_on_backend_error
check will become ineffective.

Kind regards
Muhammad Usama

On Tue, Jun 28, 2016 at 6:42 AM, Tatsuo Ishii <ishii at postgresql.org> wrote:

> Fix confusing error messages.
>
> pool_read() does not emit error messages when read(2) returns -1 if
> fail_over_on_backend_error is off. In any case the cause of error
> should be emitted. I do not back port this because it's a too trivial
> enhancement.
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=
> bb41a1e55d59f842d8b97cdbb6c973c1989904aa
>
> Modified Files
> --------------
> src/utils/pool_stream.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> _______________________________________________
> pgpool-committers mailing list
> pgpool-committers at pgpool.net
> http://www.pgpool.net/mailman/listinfo/pgpool-committers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.sraoss.jp/pipermail/pgpool-committers/attachments/20160818/0bff1af4/attachment.html>