[pgpool-committers: 2128] pgpool: while looking at the coverity issue "1222989 Bad bit shift oper

Muhammad Usama m.usama at gmail.com
Sat Aug 23 05:03:42 JST 2014

while looking at the coverity issue "1222989 Bad bit shift operation" and
"1222990 Bad bit shift operation", it has come to light that set_fd(..),
and isset_fd(..) function implementation are faulty and on top of that
for some unknown reason, these functions are trying to reinvent the wheel
by not using the standard API (fd_set) already exists for same purpose.
So this commit removes the isset_fd() and set_fd() functions and adopts
the more sane choice of using FD_SET and FD_ISSET functions.



Modified Files
src/protocol/pool_process_query.c |   49 +++++--------------------------------
1 file changed, 6 insertions(+), 43 deletions(-)

More information about the pgpool-committers mailing list