[Pgpool-hackers] pgpool_adm functions added

Tatsuo Ishii ishii at sraoss.co.jp
Thu Jun 23 06:42:49 UTC 2011


Hi,

I have committed pg_adm functions written by Jehan-Guillaume (ioguix)
de Rorthais under pgpool_adm directory. Thank you for the
contribution!

Here are some issues I notice so far:

- Compiler warning:

$ LANG=C make USE_PGXS=1 
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv -fpic -I/usr/local/pgsql/include -I. -I. -I/usr/local/pgsql/include/server -I/usr/local/pgsql/include/internal -D_GNU_SOURCE   -c -o pgpool_adm.o pgpool_adm.c
pgpool_adm.c: In function 'check_pcp_conninfo_props':
pgpool_adm.c:54: warning: comparison is always false due to limited range of data type
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv -fpic -shared -o pgpool_adm.so pgpool_adm.o -L/usr/local/pgsql/lib -Wl,--as-needed -Wl,-rpath,'/usr/local/pgsql/lib',--enable-new-dtags  -lpcp 

- No documentations
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp


More information about the Pgpool-hackers mailing list