[Pgpool-hackers] Making command proc_info returning info for all pid ?

[Jehan-Guillaume (ioguix) de Rorthais]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

I was wondering which other command I'll add in pgpool_adm so I focused
on proc_info.

But it occurs to me that using pcp_proc_info require to fetch one PID
first, so you have 2 commands to executes. More if you want to get
information about multi PID.

On the other hand, returning pcp_proc_info for ALL existing procs might
be a large set of data. But I do prefer piping a large set of data in
"less", "dog" or "more" and searching there what I need, than typing
many commands, playing with history.

So what about adding as first parameter the pgpool PID and making this
command return everything ? We can even keep reverse compatibility by
considering the PID parameter as optional: return everything if no PID
given, only informations about the PID if given.

Moreover, from the pgpool_adm point of you, I don't think I'll need to
hack the proc_count function, we will be able to get that information
with a simple query like that:

  SELECT DISTINCT pid FROM pcp_proc_info();

... We can even add this as a simple SQL function if we really want to
have it in the module:
  CREATE FUNCTION pcp_proc_count() RETURNS SETOF integer AS $$
    SELECT DISTINCT pid FROM pcp_proc_info();
  $$ LANGUAGE SQL;

Considering we could do the same kind of trick with the pcp binary
command, if pcp_proc_info returns everything, I would advice to remove
this from the protocol itself then.

Comments ?
- -- 
Jehan-Guillaume (ioguix) de Rorthais
DBA
http://www.dalibo.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3xRa4ACgkQXu9L1HbaT6L8ZACgjepprE6jlpi8MqQ2XHPINqGY
1UEAnjjVZFv2FZnXgoKIj7cHsJbIHwC8
=lAZA
-----END PGP SIGNATURE-----