[Pgpool-hackers] patch "Caching query results in pgpool-II"

[Tatsuo Ishii]

Compile is ok, but link fails.

libtool: link: gcc -g -O2 -Wall -Wmissing-prototypes -Wmissing-declarations -o .libs/pgpool main.o child.o pool_auth.o pool_config.o pool_error.o pool_process_query.o pool_stream.o pool_connection_pool.o pool_params.o pool_signal.o pcp_child.o md5.o pool_shmem.o pool_sema.o pool_system.o pool_rewrite_query.o pool_rewrite_outfuncs.o pool_query_cache.o pool_hba.o pool_path.o pool_ip.o ps_status.o strlcpy.o recovery.o pool_relcache.o pool_process_reporting.o pool_ssl.o pool_timestamp.o pool_proto2.o pool_proto_modules.o pool_lobj.o pool_process_context.o pool_memqcache.o pool_session_context.o pool_query_context.o pool_worker_child.o pool_passwd.o pool_globals.o pool_select_walker.o getopt_long.o parser/nodes.o  -L/usr/local/pgsql/lib -lpq parser/libsql-parser.a pcp/.libs/libpcp.so -lmemcached -lcrypt -lresolv -lnsl -lm -Wl,-rpath -Wl,/usr/local/lib -Wl,-rpath -Wl,/usr/local/pgsql/lib
pool_process_reporting.o: In function `get_config':
/home/t-ishii/work/pgfoundry/GSoC/pgpool-II/pool_process_reporting.c:548: undefined reference to `pool_flag_to_str'
collect2: ld returned 1 exit status

Thiis is because your patch to pool_config.c is outdated.

Also I see comipler warnings:

pool_memqcache.h:153:8: warning: extra tokens at end of #endif directive
pool_memqcache.c: In function 'memqcache_register':
pool_memqcache.c:108: warning: passing argument 1 of 'add_buf' from incompatible pointer type
pool_memqcache.c: In function 'add_buf':
pool_memqcache.c:126: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
pool_memqcache.c:126: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'
pool_memqcache.c:138: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
pool_memqcache.c:138: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'
pool_memqcache.c:138: warning: format '%d' expects type 'int', but argument 4 has type 'size_t'
pool_memqcache.c: In function 'set_cache_on_memcached':
pool_memqcache.c:170: warning: format '%d' expects type 'int', but argument 2 has type 'time_t'
pool_memqcache.c: In function 'get_cache_on_memcached':
pool_memqcache.c:220: warning: passing argument 1 of 'dump_cache_data' from incompatible pointer type
pool_memqcache.c: In function 'encode_key':
pool_memqcache.c:257: warning: unused variable 'p'
pool_memqcache.c:256: warning: unused variable 'i'
pool_memqcache.c: In function 'dump_cache_data':
pool_memqcache.c:298: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
pool_memqcache.c: In function 'send_message':
pool_memqcache.c:409: warning: implicit declaration of function 'pool_write'
pool_memqcache.c:417: warning: implicit declaration of function 'pool_flush'
pool_memqcache.c: In function 'delete_cache_related_to_tableoid':
pool_memqcache.c:489: warning: return makes integer from pointer without a cast
pool_memqcache.c:489: warning: function returns address of local variable
pool_memqcache.c:448: warning: 'fp' may be used uninitialized in this function
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp

> Errors fixed. You can compile the patch.
> sorry.
> 
> 
> 2011/7/18 Tatsuo Ishii <ishii at sraoss.co.jp>
> 
>> I tried your patches. I got those errors if I run configure without
>> memory cache enabled. Please fix.
>>
>> pool_config.l: In function ‘pool_init_config’:
>> pool_config.l:215: error: ‘POOL_CONFIG’ has no member named
>> ‘memory_cache_enabled’
>> pool_config.l:216: error: ‘POOL_CONFIG’ has no member named
>> ‘memqcache_method’
>> pool_config.l:217: error: ‘POOL_CONFIG’ has no member named
>> ‘memqcache_memcached_host’
>> pool_config.l:218: error: ‘POOL_CONFIG’ has no member named
>> ‘memqcache_memcached_port’
>> pool_config.l:219: error: ‘POOL_CONFIG’ has no member named
>> ‘memqcache_total_size’
>> pool_config.l:220: error: ‘POOL_CONFIG’ has no member named
>> ‘memqcache_expire’
>> pool_config.l:221: error: ‘POOL_CONFIG’ has no member named
>> ‘memqcache_maxcache’
>> pool_config.l:222: error: ‘POOL_CONFIG’ has no member named
>> ‘memqcache_cache_block_size’
>> pool_config.l: In function ‘pool_get_config’:
>> pool_config.l:1740: error: ‘POOL_CONFIG’ has no member named
>> ‘memory_cache_enabled’
>> pool_config.l:1758: error: ‘POOL_CONFIG’ has no member named
>> ‘memqcache_method’
>> pool_config.l:1776: error: ‘POOL_CONFIG’ has no member named
>> ‘memqcache_memcached_host’
>> pool_config.l:1788: error: ‘POOL_CONFIG’ has no member named
>> ‘memqcache_memcached_port’
>> pool_config.l:1800: error: ‘POOL_CONFIG’ has no member named
>> ‘memqcache_total_size’
>> pool_config.l:1812: error: ‘POOL_CONFIG’ has no member named
>> ‘memqcache_expire’
>> pool_config.l:1824: error: ‘POOL_CONFIG’ has no member named
>> ‘memqcache_maxcache’
>> pool_config.l:1836: error: ‘POOL_CONFIG’ has no member named
>> ‘memqcache_cache_block_size’
>> --
>> Tatsuo Ishii
>> SRA OSS, Inc. Japan
>> English: http://www.sraoss.co.jp/index_en.php
>> Japanese: http://www.sraoss.co.jp
>>