[Pgpool-hackers] removing backend_socket_dir parameter ?

[Jehan-Guillaume (ioguix) de Rorthais]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

pgPool is currently using the parameter "backend_socket_dir" to define where it
can find the backend unix socket files.

However, from the libpq world, we just use one parameter for both unix or inet
socket: host. If this parameter starts with '/', then this is a unix socket. All
other values are inet connections. See:

http://www.postgresql.org/docs/9.0/static/libpq-connect.html#LIBPQ-CONNECT-HOST

Back in pgPool world, the equivalent parameter is "backend_hostnameN". So, when
I was setting up a dev environment yesterday, I naturally set this parameter  to
my unix path (I'm using Debian) and end up with a hostname resolution error.

So you'll find in attachment a patch to remove the "backend_socket_dir"
parameter and use the libpq policy. Moreover, on empty "backend_hostnameN"
value, the patch fall back to DEFAULT_SOCKET_DIR.

I realize it will break compatibility with older configuration file. But in a
first step, I prefer something clean and start discussing this issue with you if
you really mind this.

After discussing it, if you agree to commit it at some point, I'll patch the
documentation about this behaviour as well.

Thank you,
- -- 
Jehan-Guillaume de Rorthais
DBA
http://www.dalibo.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0jIDgACgkQXu9L1HbaT6KThwCgplRC7bbFyweP3PCiuGsAcl05
zaMAoMSKQ4kndRYGD26M6O9WQ3uNKtGV
=vkYN
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: drop-backend_socket_dir-r1.patch.gz
Type: application/x-gzip
Size: 1643 bytes
Desc: not available
URL: <http://pgfoundry.org/pipermail/pgpool-hackers/attachments/20110104/a31d57d0/attachment.bin>