[Pgpool-hackers] pcp verbose display

[Guillaume Lelarge]

Le 14/08/2010 00:49, Tatsuo Ishii a écrit :
>> Here is a patch that allows pcp_node_info and pcp_proc_info to have a
>> verbose ouput. Here is an example:
>>
>> $ pcp_node_info --verbose 10 localhost 9898 postgres hogehoge 0
>> Hostname: host1
>> Username: 5432
>> Port    : 1
>> Weight  : 1073741823.500000
>>
>>
>> Comments?
> 
> Great! Output for Username and Port seems a little bit wreired?
> 

Yes, you're right. My example was bad, but the code was good.

> And following one line patch would more user friendly output for
> weiight, i.e. 0-1 range value, rather than 0-RANDMAX value. If you
> like, Please commit along with above.
> 
> Sample output;
> $ ./pcp_node_info 1 localhost 9898 postgres pgpoolAdmin 1
> localhost 5434 2 0.333333
> 

Oh, great. Love this. I commited my patch. I also commited another one
to that "SHOW pool_nodes" uses this trick too.

Thanks.

PS: once again, the english documentation has changed.


-- 
Guillaume
 http://www.postgresql.fr
 http://dalibo.com