[Pgpool-hackers] hardcoded values in configure script

[Yoshiyuki Asaba]

Hi,

From: David Fetter <david at fetter.org>
Subject: Re: [Pgpool-hackers] hardcoded values in configure script
Date: Wed, 4 Oct 2006 22:46:10 -0700

> On Thu, Oct 05, 2006 at 02:35:35PM +0900, Tatsuo Ishii wrote:
> > > Hi,
> > > 
> > > On Tue, 2006-10-03 at 10:58 +0900, Yoshiyuki Asaba wrote:
> > > > > PGSQL_INCLUDE_DIR=/usr/local/pgsql/include
> > > > > PGSQL_LIB_DIR=/usr/local/pgsql/lib
> > > > 
> > > > These are default values. So you need to give options which are
> > > > "--with-pgsql-include" and "--with-pgsql-lib". Could you try the
> > > > attached patch?
> > > 
> > > What if a person has installed PostgreSQL from sources and wants
> > > to install pgpool RPM?
> > > 
> > > I think we should set this value using pg_config.
> > 
> > How do you find the pg_config installed path then?
> 
> I think it is reasonable to assume that pg_config will be in people's
> $PATH :)

OK. If pg_config exists, default values are determined by
pg_config. If not, these are fixed path. Does anyone have any comment
to the attached patch?

Regards,
--
Yoshiyuki Asaba
y-asaba at sraoss.co.jp
-------------- next part --------------
Index: configure.in
===================================================================
RCS file: /cvsroot/pgpool/pgpool-II/configure.in,v
retrieving revision 1.2
diff -c -r1.2 configure.in
*** configure.in	22 Sep 2006 05:39:31 -0000	1.2
--- configure.in	5 Oct 2006 08:01:40 -0000
***************
*** 43,50 ****
  AC_FUNC_WAIT3
  AC_CHECK_FUNCS(setsid select socket sigprocmask strdup strerror strftime strtok asprintf)
  
! PGSQL_INCLUDE_DIR=/usr/local/pgsql/include
! PGSQL_LIB_DIR=/usr/local/pgsql/lib
  
  AC_ARG_WITH(pgsql,
      [  --with-pgsql=DIR     site header files for PostgreSQL in DIR],
--- 43,60 ----
  AC_FUNC_WAIT3
  AC_CHECK_FUNCS(setsid select socket sigprocmask strdup strerror strftime strtok asprintf)
  
! dnl Checks for pg_config command.
! AC_CHECK_PROGS(PGCONFIG, pg_config)
! 
! if test -z $PGCONFIG
! then
!   PGSQL_INCLUDE_DIR=/usr/local/pgsql/include
!   PGSQL_LIB_DIR=/usr/local/pgsql/lib
! else
!   PGSQL_INCLUDE_DIR=`pg_config --includedir`
!   PGSQL_LIB_DIR=`pg_config --libdir`
! fi
! 
  
  AC_ARG_WITH(pgsql,
      [  --with-pgsql=DIR     site header files for PostgreSQL in DIR],