[Pgpool-general] Build bug with 3.0.4 and 9.1b3

[Tatsuo Ishii]

> On 7/21/11 4:21 PM, Josh Berkus wrote:
>> All,
>> 
>> I'm working on pgpool with PostgreSQL 9.1.  Most of it works, but I
>> can't seem to build the regclass:
>> 
>> /usr/local/src/pgpool-II-3.0.4/sql/pgpool-regclass# make
>> sed 's,MODULE_PATHNAME,$libdir/pgpool-regclass,g' pgpool-regclass.sql.in
>>> pgpool-regclass.sql
>> gcc -g -O2 -fPIC -fPIC -Wall -Wmissing-prototypes -Wpointer-arith
>> -Wdeclaration-after-statement -Wendif-labels -Wformat-security
>> -fno-strict-aliasing -fwrapv -g -fpic -I. -I.
>> -I/usr/include/postgresql/9.1/server -I/usr/include/postgresql/internal
>> -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/tcl8.5  -c -o
>> pgpool-regclass.o pgpool-regclass.c
>> pgpool-regclass.c:55: error: static declaration of 'get_namespace_oid'
>> follows non-static declaration
>> /usr/include/postgresql/9.1/server/catalog/namespace.h:99: note:
>> previous declaration of 'get_namespace_oid' was here
>> make: *** [pgpool-regclass.o] Error 1
>> 
>> Note that PostgreSQL 9.1b3 was installed using Martin's Ubuntu packages.
>>  And I didn't see this issue with 3.0.3 and PostgreSQL 9.1alpha4.  Any
>> idea what the issue is?
> 
> Actually, I've confirmed that the issue was introduced in 3.0.3.,
> probably in this commit:
> 
> http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgpool/pgpool-II/sql/pgpool-regclass/pgpool-regclass.c.diff?r1=text&tr1=1.1.2.1&r2=text&tr2=1.1.2.2

No way. The problem was caused by the fact that PostgreSQL 9.1 started
to export get_namespace_oid. What pgpool-II actually want is,
non-error-raising regclass. Once I proposed that, but Tom
rejected. His answer was "use PL/pgSQL", which I don't want to accept
because it's slow. So I had to make this tricky, ugly coding.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp