[Pgpool-general] Some questions regarding pgpool-II

[Devrim GUNDUZ]

Hello Tatsuo,

David Fetter pestered me today at IRC and finally I built initial
pgpool-II and pgpoolAdmin RPMs. However I'd like to ask you some
questions:

- pgpool-II Makefile installs the following:
 * pcp.h
 * pool_type.h
 * libpcp.a

 However, I think that these are not requires for pgpool installation.
Do you consider removing them? Otherwise I'll try to build a -devel RPM
which only includes these files.

- pgpoolAdmin has some hardcoded error messages inside the code; like
status.php lines 80,91,93 and so on. Are these intentional? If not,
should we add them to language files?

- Also I have a problem running pgpoolAdmin. Here is the detail:
 pgmgt.conf has this line: define('_PGPOOL2_PCP_DIR', '/usr/bin');
 (I changed the default value to match RPM installations via a rpm
 patch)

 However, when I want to start pgpool from web interface, I get an   
 error:

 ===================================================================
 Pgpool start failed. Pgpool.pid not found

 mkdir: cannot create directory `/usr/bin/.libs': Permission denied
 /usr/bin/ld: cannot open output file /usr/bin/.libs/4125-lt-pgpool: 
 No such file or directory
 collect2: ld returned 1 exit status
 ===================================================================

 I want to assume that we will not want to create a directory (.libs)
 under /usr/bin with apache user :-) So, we may need to rethink about 
 this: Define another directory (/tmp or pgpoolAdmin installation
 directory) in conf file and create .libs there. 

- Also there are some PHP errors:
 ===================================================================

 Notice: Undefined index: pgpool2_config_file
 in /usr/share/pgpoolAdmin/install/checkParameter.php on line 40

 Notice: Undefined index: password_file
 in /usr/share/pgpoolAdmin/install/checkParameter.php on line 59

 Notice: Undefined index: pgpool_command
 in /usr/share/pgpoolAdmin/install/checkParameter.php on line 78

 Notice: Undefined index: pgpool_logfile
 in /usr/share/pgpoolAdmin/install/checkParameter.php on line 91

 Notice: Undefined index: pcp_client_dir
 in /usr/share/pgpoolAdmin/install/checkParameter.php on line 106

 Notice: Undefined index: pcp_hostname
 in /usr/share/pgpoolAdmin/install/checkParameter.php on line 132

 Notice: Undefined index: pcp_refreshTime
 in /usr/share/pgpoolAdmin/install/checkParameter.php on line 138

 Notice: Undefined variable: msgCmdC
 in /usr/share/pgpoolAdmin/install/checkParameter.php on line 298

 Notice: Undefined variable: msgCmdN
 in /usr/share/pgpoolAdmin/install/checkParameter.php on line 311

 Notice: Undefined variable: msgCmdD
 in /usr/share/pgpoolAdmin/install/checkParameter.php on line 324

 Notice: Undefined variable: msgCmdM 
 in /usr/share/pgpoolAdmin/install/checkParameter.php on line 342

 ===================================================================

Looking at the code, it is assumed that these parameters are posted from
CheckDirectory.php, but no. I believe instead of:

$pgpool2_config_file = $_POST['pgpool2_config_file']; 
if( !$pgpool2_config_file)  { 
    $pgpool2_config_file = _PGPOOL2_CONFIG_FILE;
}

we should write:

    $pgpool2_config_file = _PGPOOL2_CONFIG_FILE;

because we do not update the form here. 

Unless noone object, I'll fix this tomorrow or today.

Regards,
-- 
The PostgreSQL Company - Command Prompt, Inc. 1.503.667.4564
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Managed Services, Shared and Dedicated Hosting
Co-Authors: plPHP, plPerlNG - http://www.commandprompt.com/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://pgfoundry.org/pipermail/pgpool-general/attachments/20060926/7d0b43a4/attachment.bin