View Issue Details

IDProjectCategoryView StatusLast Update
0000548Pgpool-IIBugpublic2019-12-24 09:08
Reporterharukat Assigned Tohoshiai  
PrioritylowSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.1 beta1 
Target Version4.1 RC1Fixed in Version4.1 RC1 
Summary0000548: syslog_facility couldn't be changed by reload
DescriptionThe parameter "syslog_facility" couldn't be changed by Pgpool-II reload, even though
the document say "this parameter can be changed by reloading the Pgpool-II configurations."
TagsNo tags attached.

Activities

harukat

2019-09-27 16:25

developer   ~0002889

When I set the C preprocessor variables HAVE_SYSLOG for build like the following,
log messages flowed as new syslog facility after pgpool reloading.

  $ CFLAGS="-g -DHAVE_SYSLOG=1" ./configure --prefix /home/postgres/tmp/pgpool2_41 \
     --with-openssl --with-memcached=/usr --with-pgsql=/home/postgres/pgsql/11.3

But even if it was a build with HAVE_SYSLOG, the command "SHOW syslog_facility"
answered the old syslog_facility value after reloding.

test environment:
 CentOS6.x, x86_64, glibc-2.12-1.209.el6_9.2, rsyslog-5.8.10-8.el6

harukat

2019-09-27 16:43

developer   ~0002891

At least, I think we need to fix configure.ac like this.

  - AC_CHECK_FUNCS([strlcat, strlcpy])
  + AC_CHECK_FUNCS([strlcat, strlcpy, syslog])

harukat

2019-09-29 09:50

developer   ~0002894

This is a patch to fix this bug.

hoshiai

2019-10-01 20:03

developer   ~0002897

Thank you your report and patch.
You are right, 'HAVE_SYSLOG' was not defined properly.
I fixed your patch a little. This change vsyslog to syslog because vsyslog is not used.
bug548_pgpool_4_1.patch (3,242 bytes)   
bug548_pgpool_4_1.patch (3,242 bytes)   

hoshiai

2019-10-08 13:17

developer   ~0002911

I commited this fix.

https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=934d78132cfd2202058f0abd99e97be02244285a

hoshiai

2019-12-24 09:08

developer   ~0003027

This fix has already been fixed, so i change status of ticket to resolved

Issue History

Date Modified Username Field Change
2019-09-27 14:14 harukat New Issue
2019-09-27 14:27 hoshiai Assigned To => hoshiai
2019-09-27 14:27 hoshiai Status new => assigned
2019-09-27 16:25 harukat Note Added: 0002889
2019-09-27 16:43 harukat Note Added: 0002891
2019-09-29 09:50 harukat File Added: pgpool2_41_syslog_reloadable.patch
2019-09-29 09:50 harukat Note Added: 0002894
2019-10-01 20:03 hoshiai File Added: bug548_pgpool_4_1.patch
2019-10-01 20:03 hoshiai Note Added: 0002897
2019-10-08 13:17 hoshiai Note Added: 0002911
2019-10-16 12:43 administrator Target Version => 4.1 RC1
2019-10-16 17:39 administrator Fixed in Version => 4.1 RC1
2019-12-24 09:08 hoshiai Status assigned => resolved
2019-12-24 09:08 hoshiai Resolution open => fixed
2019-12-24 09:08 hoshiai Note Added: 0003027