View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000048 | Pgpool-II | Bug | public | 2013-01-16 05:44 | 2013-02-01 10:28 |
| Reporter | chads | Assigned To | nagata | ||
| Priority | normal | Severity | crash | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | Fedora release 17 | OS | Linux x86_64 | OS Version | 3.6.11-1 |
| Fixed in Version | 3.2 | ||||
| Summary | 0000048: watchdog crash | ||||
| Description | pthread_detach is being used wrong; causes pgpool to segfault. | ||||
| Steps To Reproduce | configure watchdog in pgpool.conf | ||||
| Additional Information | included a patch that resolves the issue | ||||
| Tags | No tags attached. | ||||
|
|
|
|
|
I found a few more instances of pthread_detach being used wrong. I'm attaching an updated patch. |
|
|
|
|
|
I agree to remove unnecessary pthread_detach() that cause segfault. However, adding pthread_detach(pthread_self()) in the thread function isn't adequate, because the thread should return a value. I think, we should use only pthread_join, and remove all pthread_detach. |
|
|
Continued testing revealed problems with using pthread_self(), especially in regards wd_lifecheck. I agree; continue to use pthread_join(), which is required, and remove the pthread_detach() calls. |
|
|
|
|
|
I confirmed that your new patch works well. We'll adopt this into the next release. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-01-16 05:44 | chads | New Issue | |
| 2013-01-16 05:44 | chads | File Added: pthread_detach.patch | |
| 2013-01-16 10:08 | anzai | Assigned To | => nagata |
| 2013-01-16 10:08 | anzai | Status | new => assigned |
| 2013-01-16 22:21 | chads | Note Added: 0000217 | |
| 2013-01-16 22:21 | chads | File Added: pthread_detach.patch-20120116 | |
| 2013-01-17 15:21 | nagata | Note Added: 0000218 | |
| 2013-01-17 23:18 | chads | Note Added: 0000219 | |
| 2013-01-17 23:19 | chads | File Added: pthread_detach-20130117.patch | |
| 2013-02-01 10:27 | nagata | Note Added: 0000223 | |
| 2013-02-01 10:28 | nagata | Status | assigned => resolved |
| 2013-02-01 10:28 | nagata | Fixed in Version | => 3.2 |
| 2013-02-01 10:28 | nagata | Resolution | open => fixed |
