View Issue Details

IDProjectCategoryView StatusLast Update
0000158Pgpool-IIBugpublic2016-05-06 17:35
ReporterpgdudeAssigned ToMuhammad Usama 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionopen 
PlatformlinuxOSRedhatOS Version7
Product Version 
Target VersionFixed in Version 
Summary0000158: pgpool web console gets pgpool.conf parameters incorrectly
DescriptionThe format of the pgpool.conf file says:
 Whitespace may be used. Comments are introduced with "#" anywhere on a line.

But if you move comments to the same line as the parameter, the entire line gets captured as that parameter when refreshing node info. in web console

postgresql log:
user=postgres # Health check user,db=template1 10.11.12.120(42163) FATAL: password authentication failed for user "postgres # Health check user"

pgpool.conf file:

health_check_user = 'postgres' # Health check user

but if I change it to:
health_check_user = 'postgres'
                                 # Health check user

no more errors in postgresql log file
Steps To Reproduceput comments on same line as health_check_user in pgpool.conf
health_check_user = 'postgres' # Health check user

open web console and press the "Node Info." button

You will see these errors in postgresql log file:
user=postgres # Health check user,db=template1 10.11.12.120(42163) FATAL: password authentication failed for user "postgres # Health check user"
Additional InformationInterestingly, by default, pgpool.conf has comments on next line after a parameter definition. This default format would never result in the problem I saw in web console.

But I was trying to reduce the number of lines in pgpool.conf by starting comment on same line as parameter, and it works when running pgpool in HA mode (watchdog), but not with web console, which must be reading the pgpool.conf file differently, expecting comments on separate lines.
TagsNo tags attached.

Activities

anzai

2016-04-20 18:01

developer   ~0000788

I think this doen't occur now. I fixed this problem of pgpoolAdmin on the day this issue had been submitted.
I added trimValue() function in common.php, so that pgpoolAdmin can get the parameter value itself from a line with '#' comment.

http://git.postgresql.org/gitweb?p=pgpooladmin.git;a=commitdiff;h=2d73b1f89b489b4064c80f12ea8423ae096c142c

Issue History

Date Modified Username Field Change
2015-12-02 04:27 pgdude New Issue
2016-04-07 08:07 t-ishii Assigned To => Muhammad Usama
2016-04-07 08:07 t-ishii Status new => assigned
2016-04-20 18:01 anzai Note Added: 0000788
2016-05-06 17:35 t-ishii Status assigned => resolved