|
|
Before entering the code fragment you showed, send_to_where() is called: dest = send_to_where(node, query); and "dest" will be set to POOL_PRIMARY and never reaches to the code fragment. If you actually tested and find the case pgpool sends SELECT having writing functions to standby, please let us know. |
|
|
I do not seem to see the code about writing function checking in the send_to_where(). I haven't actually tested it yet. Okay, I'll simulate a test to see if it works image.png (50,773 bytes) |
|
|
Sorry, I was wrong. send_to_where() does not check whether the SELECT has writing functions or not. So the code path you mentioned was correct. However, int new_load_balancing_node = select_load_balancing_node(); select_load_balancing_node() will check standby delay and set the new load balance node id to primary if the delay is too much. So the SELECT will be sent to the primary node. |
|
|
If there is also a standby node and the delay does not exceed the threshold, it will be choiced. And the original intention here is to choose a standby with the lowest delay and not the primary, unless there is no other choice. so, maybe the judgment of replication delay in figure 2 should be moved to the position shown in figure 3 image-2.png (55,620 bytes) image-3.png (52,829 bytes) image-4.png (95,395 bytes) |
|
|
> If there is also a standby node and the delay does not exceed the threshold, it will be choiced. Good point. In this case pgpool may send write query to the standby node. Thank you for the suggestion to fix the code. I will take care of this. |
|
|
I would like to credit your name in the commit log if you like. What would you like to appear your name? |
|
|
that’s ok |
|
|
Ok, I have not included your name in the commit log. I just mentioned that the bug was reported and fix were suggested. https://git.postgresql.org/gitweb/?p=pgpool2.git;a=commit;h=c7f9be67e28cee86064df807f2a98920e3c47c6e Thank you so much! |
- Anonymous
