View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000596 | Pgpool-II | Bug | public | 2020-03-12 14:17 | 2020-05-21 11:29 |
| Reporter | gregn123 | Assigned To | t-ishii | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | open | ||
| Product Version | 4.1.0 | ||||
| Target Version | 4.1.2 | Fixed in Version | 4.1.2 | ||
| Summary | 0000596: Problems in watchdog processing json data | ||||
| Description | In the watchdog source code (src/watchdog/wd_json_data.c), there are some instances of bad handling of values read from json data. For example: 1) The boolean pool configuration settings "load_balance_mode" and "master_slave_mode" are read using json_get_int_value_for_key(), resulting in 4-bytes being written into their location within the POOL_CONFIG, yet (being bool) they are only 1-byte long. This corrupts the values of the structure members following them. 2) Similarly, when parsing node function json data, "Flags" is read using json_get_int_value_for_key(), resulting in 4-bytes being written into an "unsigned char flags" variable on the stack, overwriting 3-bytes of stack memory following it. On a big-endian system (e.g. Solaris-sparc or Linux for IBM Z), this causes regression test "013.watchdog_failover_require_consensus" to fail, since 0 is written into Flags, rather than the intended value which is in the least significant byte of the int value written. I have attached a patch to correct these issues (gpool2_watchdog_json_handling_issues.patch). Please review. | ||||
| Steps To Reproduce | Run the pgpool2 regression tests on a big-endian system (e.g. Solaris-sparc or Linux on IBM Z), and test 013 will fail. (To build pgpool2 properly on these systems, I found it necessary to specify -DWORDS_BIGENDIAN in CFLAGS when running the configure script, as it's otherwise not accounting for it. My other fix for SCRAM authentication may also be needed - see issue 0000595). The corruptions will occur on all systems, but these may or may not cause obvious issues. | ||||
| Tags | watchdog | ||||
|
|
|
|
|
Thank you! Patch looks good. I am going to commit it. (please let me know your name so that I can credit your name in a commit message). |
|
|
Greg Nancarrow (Fujitsu Australia) |
|
|
Patch pushed. Thanks! |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-03-12 14:17 | gregn123 | New Issue | |
| 2020-03-12 14:17 | gregn123 | File Added: pgpool2_watchdog_json_handling_issues.patch | |
| 2020-03-12 14:17 | gregn123 | Tag Attached: watchdog | |
| 2020-03-12 16:32 | t-ishii | Assigned To | => t-ishii |
| 2020-03-12 16:32 | t-ishii | Status | new => assigned |
| 2020-03-12 20:56 | t-ishii | Note Added: 0003264 | |
| 2020-03-13 08:51 | t-ishii | Status | assigned => feedback |
| 2020-03-13 08:51 | t-ishii | Description Updated | |
| 2020-03-13 08:51 | t-ishii | Steps to Reproduce Updated | |
| 2020-03-13 09:23 | gregn123 | Note Added: 0003265 | |
| 2020-03-13 09:23 | gregn123 | Status | feedback => assigned |
| 2020-03-13 10:50 | t-ishii | Note Added: 0003268 | |
| 2020-03-13 10:51 | t-ishii | Target Version | => 4.1.2 |
| 2020-03-13 17:27 | t-ishii | Status | assigned => feedback |
| 2020-05-21 11:29 | administrator | Status | feedback => closed |
| 2020-05-21 11:29 | administrator | Fixed in Version | => 4.1.2 |
